Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bg/openPayments): handle tab close before accept #627

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

sidvishnoi
Copy link
Member

Reject if user closes tab before accepting. Prevent leaving a dangling tab watcher.

Rejection not need to be handled at the moment, but will be handled as a part of #626 so we can show user any errors or progress as needed.

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Sep 25, 2024
Copy link
Contributor

Extension builds preview

Name Link
Latest commit fc04b01
Latest job logs Run #11035248077
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi merged commit 4559b9c into main Sep 25, 2024
9 checks passed
@sidvishnoi sidvishnoi deleted the handle-tab-close-before-accept branch September 25, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants