Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include URL in BrowserThread name, so it will be part of every log li… #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blekinge
Copy link

Include the URL in the browserthread name, so it will be logged explicitly.
As it seems that each browserthread is created to handle exactly one URL, having both the URL and the chrome port name as part of the thread name makes sense. And for debugging, it is a LOT easier to read the logs

…ne from Browser thread. Thus, do not log it explicitly
@nlevitt
Copy link
Contributor

nlevitt commented May 17, 2019

Url can be very very long. It's too much I think. It's pretty easy to track a url in the logs by grepping for the browser port as you point out. The url is logged on a line like this:

2019-01-29 22:34:50,264 21163 INFO BrowsingThread:35490 umbra.controller.AmqpBrowserController.browse_page_sync(controller.py:284) browser=... client_id=... url=... behavior_parameters=...

Then all the subsequent lines with :35490 are about that url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants