-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use concrete signature types #715
Conversation
It looks like a simple But the right solution seems to be to introduce a |
bip44 PR. You can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like this
.into_iter()
.map(Segment::harden)
.collect(),
Maybe we can add a helper method to Segment or something?
edit: ah i see vlad thought the same-ish :D
fcddc52
to
8657b27
Compare
Co-authored-by: Thibault Martinez <[email protected]>
Description of change
This PR updates crypto and stronghold, and replaces byte arrays with the concrete crypto types.
Links to any relevant issues
Ed25519Signature
could use stronghold/crypto types #511Type of change
Choose a type of change, and delete any options that are not relevant.