fix: dont use local storage for text config items #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…-storage-input-with-it
3 tasks
SgtPooki
commented
Nov 14, 2024
| @@ -76,13 +77,9 @@ const dnsJsonValidationFn = (value: string): Error | null => { | |||
| } | |||
| } | |||
|
|
|||
| const stringValidationFn = (value: string): Error | null => { | |||
There was a problem hiding this comment.
validation function is optional, and we only use this for debug. removing and not passing validation function for debug input
Comment on lines
+40
to
+55
| /** | ||
| * We need to make sure that the configDb types are loaded with the values from IDB | ||
| */ | ||
| useEffect(() => { | ||
| void (async () => { | ||
| const config = await getConfig(getUiComponentLogger('config-context')) | ||
| setGateways(config.gateways) | ||
| setRouters(config.routers) | ||
| setDnsJsonResolvers(config.dnsJsonResolvers) | ||
| setEnableWss(config.enableWss) | ||
| setEnableWebTransport(config.enableWebTransport) | ||
| setEnableGatewayProviders(config.enableGatewayProviders) | ||
| setEnableRecursiveGateways(config.enableRecursiveGateways) | ||
| setDebug(config.debug) | ||
| })() | ||
| }, []) |
There was a problem hiding this comment.
it would be nice if we could do this faster..
Comment on lines
+31
to
+38
| const [gateways, setGateways] = useState<string[]>([]) | ||
| const [routers, setRouters] = useState<string[]>([]) | ||
| const [dnsJsonResolvers, setDnsJsonResolvers] = useState<Record<string, string>>({}) | ||
| const [enableWss, setEnableWss] = useState(false) | ||
| const [enableWebTransport, setEnableWebTransport] = useState(false) | ||
| const [enableGatewayProviders, setEnableGatewayProviders] = useState(false) | ||
| const [enableRecursiveGateways, setEnableRecursiveGateways] = useState(false) | ||
| const [debug, setDebug] = useState('') |
SgtPooki
deleted the
447-create-input-component-and-replace-local-storage-input-with-it
branch
SgtPooki
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: dont use local storage for text config items
Description
Loads config in config-context.tsx, and provides that in config.tsx, and updates save function to save text-input items from context-context to IDB
Fixes #447
Notes & open questions
See #446 for more changes coming.
Change checklist