fix: input toggles dont use localStorage #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
SgtPooki
force-pushed
the
449-create-toggle-component-and-replace-local-storage-toggle-with-it
branch
from
b95d53c
to
5e4edf1
Compare
3 tasks
Base automatically changed from
447-create-input-component-and-replace-local-storage-input-with-it
to
main
November 14, 2024 13:54
SgtPooki
commented
Nov 14, 2024
Comment on lines
+79
to
+83
| const resp = await fetch('/#/ipfs-sw-config-reload') | ||
|
|
||
| if (!resp.ok) { | ||
| throw new Error('Failed to reload config') | ||
| } |
There was a problem hiding this comment.
Need to call the endpoint manually instead of using tellSwToReloadConfig because this is executed inside the page
…l-storage-toggle-with-it
SgtPooki
deleted the
449-create-toggle-component-and-replace-local-storage-toggle-with-it
branch
SgtPooki
added a commit
that referenced
this pull request
Nov 14, 2024
* fix: dont use local storage for text config items * fix: input toggles dont use localStorage * fix: input-toggle uses resetKey * fix: do not use broadcast channels to tell sw to update config * chore: fix build * chore: dont set debug var by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: input toggles dont use localStorage
Description
Removes the last of the localStorage use for inputs on the config page. Merging this and #448 should unblock #399 & #446.
This change also removes the HeliaCommsChannel broadcast channel, and instead does a request to
/#/ipfs-sw-config-reloadto tell the SW to update verified fetch. This has resulted in much more consistent updates of the service worker when new config is saved.Fixes #449
Notes & open questions
Change checklist