Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Position Threshold Check for State Transitions #1273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DorsaRoh
Copy link
Contributor

@DorsaRoh DorsaRoh commented Oct 19, 2024

Description

Adds a position threshold check, resolving 3 TODO error comments, to ensure the robot's end effector is within a specified distance from the target position before transitioning between states in the pick and lift state machine. Improves the precision of state transitions and helps prevent premature actions during object manipulation. I.e, the threshold ensures the robot is "close enough" to the target position before proceeding, reducing the likelihood of failed grasps or incorrect movements.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

Not applicable for this change

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@DorsaRoh DorsaRoh changed the title Add Position Threshold Check for State Transitions Fix: Position Threshold Check for State Transitions Oct 19, 2024
@DorsaRoh DorsaRoh changed the title Fix: Position Threshold Check for State Transitions Fix Position Threshold Check for State Transitions Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant