-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Units + Lang Support for Chapter Interval Metadata Setting #6158
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Cloudflare Pages deployment
|
<div class="fieldDescription">${LabelDummyChapterDurationHelp}</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the blank line - don't make unrelated changes.
@@ -22,8 +22,9 @@ <h2 style="margin-top:0;">${HeaderPreferredMetadataLanguage}</h2> | |||
<div class="verticalSection"> | |||
<h2>${HeaderDummyChapter}</h2> | |||
<div class="inputContainer"> | |||
<input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration}" min="0"></input> | |||
<input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration} ${LabelUnits}" min="0 seconds"></input> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LabelUnits
is too generic. Maybe add unit to LabelDummyChapterDuration
?
} | ||
"HearingImpairedShort": "HI/SDH", | ||
"LabelUnits": "(sekondes)" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert changes to languages other than en-us
. Only Weblate should be used to work with other languages.
@@ -22,8 +22,9 @@ <h2 style="margin-top:0;">${HeaderPreferredMetadataLanguage}</h2> | |||
<div class="verticalSection"> | |||
<h2>${HeaderDummyChapter}</h2> | |||
<div class="inputContainer"> | |||
<input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration}" min="0"></input> | |||
<input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration} ${LabelUnits}" min="0 seconds"></input> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of the min attribute is invalid
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Changes
Used translation script to add seconds text to all json str files. Called from metadataimages.html to show units
Issues
#5555
ex. Fixes # -->#5555