-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Units + Lang Support for Chapter Interval Metadata Setting #6158
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,8 +22,9 @@ <h2 style="margin-top:0;">${HeaderPreferredMetadataLanguage}</h2> | |
<div class="verticalSection"> | ||
<h2>${HeaderDummyChapter}</h2> | ||
<div class="inputContainer"> | ||
<input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration}" min="0"></input> | ||
<input is="emby-input" type="number" id="valDummyChapterDuration" label="${LabelDummyChapterDuration} ${LabelUnits}" min="0 seconds"></input> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The value of the min attribute is invalid |
||
<div class="fieldDescription">${LabelDummyChapterDurationHelp}</div> | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove the blank line - don't make unrelated changes. |
||
</div> | ||
<div class="selectContainer"> | ||
<select is="emby-select" id="txtChapterImageResolution" label="${LabelChapterImageResolution}"></select> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -874,5 +874,6 @@ | |
"ForeignPartsOnly": "Slegs gedwonge/vreemde onderdele", | ||
"AiTranslated": "AI Vertaal", | ||
"MachineTranslated": "Masjien Vertaal", | ||
"HearingImpairedShort": "HI/SDH" | ||
} | ||
"HearingImpairedShort": "HI/SDH", | ||
"LabelUnits": "(sekondes)" | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert changes to languages other than |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
{} | ||
{ | ||
"LabelUnits": "(seconds)" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LabelUnits
is too generic. Maybe add unit toLabelDummyChapterDuration
?