addGraph function return value fixed #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
jkriege2
added a commit
that referenced
this pull request
Oct 17, 2024
…mirror the interface of JKQTBasePlotter), fixes issue #140
Snolandia
pushed a commit
to Snolandia/JKQtPlotter
that referenced
this pull request
Nov 22, 2024
authored-by: Sajad Hosseini <[email protected]>
Snolandia
pushed a commit
to Snolandia/JKQtPlotter
that referenced
this pull request
Nov 22, 2024
…mirror the interface of JKQTBasePlotter), fixes issue jkriege2#140
Snolandia
added a commit
to Snolandia/JKQtPlotter
that referenced
this pull request
Nov 22, 2024
This reverts commit fd985dc.
Snolandia
added a commit
to Snolandia/JKQtPlotter
that referenced
this pull request
Nov 22, 2024
…ter (to mirror the interface of JKQTBasePlotter), fixes issue jkriege2#140" This reverts commit 1e0d996.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite basePlotter returning the graph id, Plotter does not pass it to the caller, so I changed it to do so.
For upcoming actions, it is important to have the identity of the added graph. The graph id can't be retrieved any easier than this.
It is necessary to preserve backward compatibility with v4.0.3.