Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the url hash of the renderer to manage code objects visibility (Abandonned) #120

Closed
wants to merge 4 commits into from

Conversation

etienneCharignon
Copy link
Collaborator

@etienneCharignon etienneCharignon commented Sep 22, 2018

All this started with the issue #113, about helping users to find their code object among others in the programmer view.

In the process of introducing a "solo" mode we identified the need of an interface between the programmer view and the renderer.

This PR is about implementing this interface using the URL of the renderer:

Here are the supported options, as an example with a playground named pg:

  • https://paysage.xyz/playground/pg#only=myCodeId to show only one code,
  • https://paysage.xyz/playground/pg# to show all codes,
  • https://paysage.xyz/playground/pg#only= to show none.

This PR is also providing a mean to show a specific list of codeIds what is not be necessary for implementing the solo mode, but might be useful for more advanced behaviours:
https://paysage.xyz/playground/pg#only=codeId1,codeId2

This last point is open to comment (among any other review comments). Do we want to keep this ?

@jonathanperret jonathanperret temporarily deployed to paysage-test-pr-120 September 22, 2018 13:36 Inactive
@jonathanperret jonathanperret temporarily deployed to paysage-test-pr-120 September 22, 2018 14:22 Inactive
@jonathanperret jonathanperret temporarily deployed to paysage-test-pr-120 September 22, 2018 14:25 Inactive
@jonathanperret
Copy link
Owner

Why introduce #none? What's ambiguous with #only= (with no ids)?

@jonathanperret jonathanperret temporarily deployed to paysage-test-pr-120 September 23, 2018 06:20 Inactive
@etienneCharignon
Copy link
Collaborator Author

The main reason is the path of my thoughts. I realized that I needed a way to express #none, which made me bring back the #only keyword. Before that, I was juste requesting the list of Ids immediately after the #. I did not see that juste adding #only= would solve my problem entirely. Ok, then lets remove #none

@jonathanperret jonathanperret temporarily deployed to paysage-test-pr-120 September 23, 2018 07:04 Inactive
@etienneCharignon
Copy link
Collaborator Author

I found out that this is not working because the paysage renderer do not keep its preview state when receiving a new code object. The new code object is display however it is not listed on the URL.

I'm closing this PR and will comme back with a new PR later on.

@etienneCharignon etienneCharignon changed the title Use the url hash of the renderer to manage code objects visibility Use the url hash of the renderer to manage code objects visibility (Abandonned) Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants