Change out_dir on m1 macbook #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for /usr/local/bin migration to /bin on m1 macbook air
jpillora
reviewed
Jan 10, 2022
| @@ -52,6 +52,9 @@ function install { | |||
| ARCH="amd64" | |||
| elif uname -m | grep arm > /dev/null; then | |||
| ARCH="arm" #TODO armv6/v7 | |||
| if OS == "Darwin"; then | |||
| OUT_DIR='/bin' | |||
There was a problem hiding this comment.
isn't /bin for system binaries?
i think dangerous to use /bin because you might accidentally overwrite your ls program
There was a problem hiding this comment.
This is due to the new mac upgrades (m1 chip specifically) moving everything to /bin. Its the new "apple way to do things" which is why i made sure we were on darwin before changing the out_dir first. linux machines are as you described.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for /usr/local/bin migration to /bin on m1 macbook air
Fixes Issue #20