Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change out_dir on m1 macbook #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change out_dir on m1 macbook #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ function install {
ARCH="amd64"
elif uname -m | grep arm > /dev/null; then
ARCH="arm" #TODO armv6/v7
if OS == "Darwin"; then
OUT_DIR='/bin'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't /bin for system binaries?

i think dangerous to use /bin because you might accidentally overwrite your ls program

Copy link
Author

@justyntemme justyntemme Jan 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to the new mac upgrades (m1 chip specifically) moving everything to /bin. Its the new "apple way to do things" which is why i made sure we were on darwin before changing the out_dir first. linux machines are as you described.

fi
elif uname -m | grep 386 > /dev/null; then
ARCH="386"
else
Expand Down