Fix CD pipeline builds for OSX and Windows #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmalec Thank you for fixing this. |
|
@jrincayc You're welcome, thank you for the quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few things preventing the CD pipeline from running successfully.
OSX
Relatively small tweaks to the way wxWidgets is installed on the build node:
sudonow appears to be required.autoconfneeds to have the wxWidgets m4 file manually installed.Windows Inno Version
Windows build nodes now provide Inno 6.3.3 as part of the default set of tools. 6.1.2 now causes some instability, so removing this and just using the provided version which seems to work fine.
Windows sleep Function
The Windows build nodes had been treating the appearance of
sleepin the C code as a warning; but, now seem to treat this as an error. There should be no change in runtime behavior since thesleepappears after areturnstatement in wxWidgets builds of the code; but, the change in macros should prevent the code that won't execute from being compiled.OSX Caveat
It looks like the build nodes will no longer compile for versions of OSX prior to 11 by default. I have a thought on how we may be able to continue compiling for 10.14+ rather than 11+ but wanted to get the CD pipelines back into working state before tackling that.
Test Environments