-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google_chat_ros: enable to get therad_name message result #498
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
I have created PR, how about enabling :ac option. Beacuase current implementation initialize publisher/subscriber everytime we call function. This is good for example code, but hard to use in demo code.
Yes, I think it is hard to use in demo, so I agree with this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so merge #496 ?
#496 (comment) says
so pass SimpleActionClient and return result? |
I mean enabling the option
and if the :ac is set, the function uses it. |
another imprementation of #496
@mqcmd196 I have created PR, how about enabling
:ac
option. Beacuase current implementation initialize publisher/subscriber everytime we call function. This is good for example code, but hard to use in demo code.