Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_rosbag_tools] set python_interpreter python2 for melodic, install scipy<1.9.0+numpy>=1.21.0 for python3 and apt scipy+numpy<1.21.0 for python2 #1781

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Mar 20, 2023

this PR solves #1780
typeDict is deprecated in numpy>=1.21.0 in scipy

For python3, I install scipy in catkin_virtualenv to upgrade scipy.
https://stackoverflow.com/questions/74852225/attributeerror-module-numpy-has-no-attribute-typedict/74969328#74969328

scipy version should be 1.9.0 because of openblas problem with meson.
scipy/scipy#16308

For python2, I install numpy<1.21.0 to avoid attribute error.

So I made two requirements for python2 and python3.

  • python3:
    • scipy<1.9.0 (because of meson build error)
    • numpy>=1.21.0 (scipy requires this version)
  • python2
    • scipy from apt
    • numpy<1.21.0(because of typeDict attribute error)

this PR also specify the python interpreter as python2 for melodic.

@knorth55 knorth55 requested a review from iory March 20, 2023 09:07
@knorth55 knorth55 changed the title install numpy<1.21.0 to avoid attribute error in scipy [jsk_rosbag_tools] install numpy<1.21.0 to avoid attribute error in scipy Mar 20, 2023
@knorth55 knorth55 changed the title [jsk_rosbag_tools] install numpy<1.21.0 to avoid attribute error in scipy [jsk_rosbag_tools] install upgraded scipy in virtualenv to avoid numpy error Mar 20, 2023
@knorth55
Copy link
Member Author

This PR passed all tests.
This PR fixes the build error of master branch reported in #1780.

@knorth55
Copy link
Member Author

knorth55 commented Mar 22, 2023

I update this PR.
I found that scipy<1.9.0 needs numpy>=1.21.0, and numpy>=1.21.0 only supports python3.

So I made two requirements for python2 and python3.

  • python3:
    • scipy<1.9.0 (because of meson build error)
    • numpy>=1.21.0 (scipy requires this version)
  • python2
    • scipy from apt
    • numpy<1.21.0(because of typeDict attribute error)

@knorth55 knorth55 changed the title [jsk_rosbag_tools] install upgraded scipy in virtualenv to avoid numpy error [jsk_rosbag_tools] install scipy<1.9.0+numpy>=1.21.0 for python3 and apt scipy+numpy<1.21.0 for python2 Mar 22, 2023
@knorth55 knorth55 changed the title [jsk_rosbag_tools] install scipy<1.9.0+numpy>=1.21.0 for python3 and apt scipy+numpy<1.21.0 for python2 [jsk_rosbag_tools] set python_interpreter python2 for melodic, install scipy<1.9.0+numpy>=1.21.0 for python3 and apt scipy+numpy<1.21.0 for python2 Mar 22, 2023
@k-okada k-okada merged commit 8d6ff58 into jsk-ros-pkg:master Mar 23, 2023
@knorth55 knorth55 deleted the rosbag-tools-numpy-version branch March 23, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants