Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to build in Ubuntu 22.04/24.04 #2829

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Changes to build in Ubuntu 22.04/24.04 #2829

wants to merge 10 commits into from

Commits on Apr 29, 2024

  1. need diagnostic_updater in package.xml and CMakeLists.txt order to in… 

    …clude timered_diagnostic_updater.h in pcl_util.h
    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6329f71 View commit details
    Browse the repository at this point in the history

  2. use std::isfinite instead of pcl_isfinite which is no longer defined-… 

    … though could make code more compact with pcl::isFinite()
    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ffcf628 View commit details
    Browse the repository at this point in the history

  3. jsk_pcl_ros_utils needs vtk because pcl needs it otherwise '/usr/incl… 

    …ude/pcl-1.12/pcl/io/vtk_lib_io.h:55:10: fatal error: vtkSmartPointer.h: No such file or directory'
    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0bcca4d View commit details
    Browse the repository at this point in the history

  4. add dependency on jsk_data and rostest

    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    32a10eb View commit details
    Browse the repository at this point in the history

  5. use hpp instead of deprecated .h pluginlib headers

    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e0b08f0 View commit details
    Browse the repository at this point in the history

  6. disabling cython because of 'fatal error: longintrepr.h: No such file… 

    … or directory'
    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    50bbaad View commit details
    Browse the repository at this point in the history

  7. provide return values

    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5d6bf07 View commit details
    Browse the repository at this point in the history

  8. removing setup.py and catkin_python_setup() from jsk_recognition_msgs… 

    …, it doesn't have any src python for other packages to import
    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ef870de View commit details
    Browse the repository at this point in the history

  9. need to put eigen_conversions and tf_conversions so other packages li… 

    …ke jsk_rviz_plugins can include their headers
    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c723e46 View commit details
    Browse the repository at this point in the history

  10. using boost::placeholders for _1, _2, etc.

    @lucasw
    lucasw committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    73f7a31 View commit details
    Browse the repository at this point in the history