Uses numeric_value in MEDS for predicates with numerical criteria

[justin13601]

Summary by CodeRabbit

• Documentation

  • Updated configuration documentation to clarify the handling of value_max in the MEDS format.
  • Specified structure and components of the configuration file, including predicates and window configurations.

• Bug Fixes

  • Corrected the reference from numerical_value to numeric_value in the MEDS format for improved accuracy.
  • Enhanced error handling for invalid specifications in the configuration.

• Improvements

  • Improved validation for window boundaries and enhanced error messages for better debugging.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve updates to the configuration language for extracting task dataframes and cohorts from structured EHR data in MEDS and ESGPT formats. Key modifications include the renaming of numerical_value to numeric_value in the PlainPredicateConfig class, enhancements to error handling in evaluation methods, and improved validation for window boundaries in the WindowConfig class.

Changes

File	Change Summary
docs/source/configuration.md	Updated value_max reference from numerical_value to numeric_value in PlainPredicateConfig.
src/aces/config.py	Renamed numerical_value to numeric_value in MEDS_eval_expr and ESGPT_eval_expr methods. Enhanced error handling and validation in WindowConfig.

Possibly related PRs

• MEDS sample data code tutorial #134: The changes in the main PR regarding the PlainPredicateConfig class and the handling of value_max and numeric_value are relevant to the MEDS data tutorial, as it likely covers the configuration language and its components, including predicates, which are central to the tutorial's focus on MEDS data.

Poem

In the fields where data flows,
A rabbit hops where knowledge grows.
With numeric_value shining bright,
Configs dance in pure delight.
Windows open, errors mend,
A leap of joy, our work transcends! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
src/aces/config.py	97.62% <100.00%> (ø)