Fix broken link to karmada controllers #703
Conversation
karmada-bot
added
the
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/XS
|
Hi @LavredisG, thanks for your contribution! |
| @@ -51,7 +51,7 @@ The karmada-controller-manager runs various custom controller processes. | |||
|
|
|||
| The controllers watch Karmada objects and then talk to the underlying clusters' API servers to create regular Kubernetes resources. | |||
|
|
|||
| The controllers are listed at [Karmada Controllers](../administrator/configuration/configure-controllers/#karmada-controllers). | |||
There was a problem hiding this comment.
This link works on my side: https://karmada.io/docs/administrator/configuration/configure-controllers/#karmada-controllers.
@XiShanYongYe-Chang How about you?
There was a problem hiding this comment.
Hey, website seems to be working for me too now (maybe I was reading an older docs version?). Link only breaks down when you try to access the docs via github (from here for example: https://github.com/karmada-io/website/blob/main/docs/core-concepts/components.md). Would you suggest that to be fixed or it's ok as long as the website is functional?
There was a problem hiding this comment.
The link format is used everywhere on the website, I don't think it's worth it to fix them all.
But thanks for spotting, it's my first time trying to navigate the doc from the markdown file though. :)
There was a problem hiding this comment.
Agreed, since website is ok, I also think there's no reason to fix them. Glad to help! I will proceed to close this PR
There was a problem hiding this comment.
Thank you all the same. Looking forward to your contribution.
It works on my side too. Hi @LavredisG What kind of mistake did you show? |
/kind documentation