Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link to karmada controllers #703

Closed
wants to merge 1 commit into from
Closed

Fix broken link to karmada controllers #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/core-concepts/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The karmada-controller-manager runs various custom controller processes.

The controllers watch Karmada objects and then talk to the underlying clusters' API servers to create regular Kubernetes resources.

The controllers are listed at [Karmada Controllers](../administrator/configuration/configure-controllers/#karmada-controllers).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link works on my side: https://karmada.io/docs/administrator/configuration/configure-controllers/#karmada-controllers.

@XiShanYongYe-Chang How about you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, website seems to be working for me too now (maybe I was reading an older docs version?). Link only breaks down when you try to access the docs via github (from here for example: https://github.com/karmada-io/website/blob/main/docs/core-concepts/components.md). Would you suggest that to be fixed or it's ok as long as the website is functional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link format is used everywhere on the website, I don't think it's worth it to fix them all.
But thanks for spotting, it's my first time trying to navigate the doc from the markdown file though. :)

Copy link
Contributor Author

@LavredisG LavredisG Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, since website is ok, I also think there's no reason to fix them. Glad to help! I will proceed to close this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all the same. Looking forward to your contribution.

The controllers are listed at [Karmada Controllers](../administrator/configuration/configure-controllers.md/#karmada-controllers).

### karmada-scheduler

Expand Down