Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Selenium unit test passes #6246

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: Selenium unit test passes #6246

merged 1 commit into from
Oct 21, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 16, 2024 •
edited
Loading

I merged a PR that doesn't pass the test, IDK how 🤦

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

@JorTurFer
fix: Selenium unit test passes
f002adc 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer requested a review from a team as a code owner October 16, 2024 17:51
@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 16, 2024 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) October 16, 2024 17:56
@JorTurFer
Copy link
Member Author

This PR solves the issue as the test has been modified there too -> #6169

@JorTurFer JorTurFer closed this Oct 16, 2024
@JorTurFer JorTurFer reopened this Oct 16, 2024
@JorTurFer JorTurFer enabled auto-merge (squash) October 16, 2024 18:09
@rickbrouwer rickbrouwer mentioned this pull request Oct 17, 2024
Merged
3 tasks
@leevilehtonen leevilehtonen mentioned this pull request Oct 20, 2024
Open
7 tasks
@wozniakjan wozniakjan mentioned this pull request Oct 21, 2024
Merged
4 tasks
@wozniakjan
Copy link
Member

wozniakjan commented Oct 21, 2024 •
edited
Loading

I merged a PR that doesn't pass the test, IDK how

happens to anyone :)
this one however seems to pass and has couple of approvals, I will get this in so other PRs don't get false negatives on unit tests

@wozniakjan wozniakjan merged commit 7e44dc7 into kedacore:main Oct 21, 2024
32 checks passed
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Oct 21, 2024
@JorTurFer @rickbrouwer
fix: Selenium unit test passes (kedacore#6246)
05fcee8 
Signed-off-by: Jorge Turrado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @wozniakjan @zroubalik