Added new dependency on keras_nlp #2419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyashreepathihalli
requested changes
Apr 22, 2024
divyashreepathihalli
approved these changes
Apr 22, 2024
|
Shouldn't we have this here too? |
smitlg
reviewed
Apr 23, 2024
Co-authored-by: Smit Lunagariya <[email protected]>
sampathweb
requested changes
Apr 27, 2024
| @@ -76,6 +76,7 @@ def is_pure(self): | |||
| "tensorflow-datasets", | |||
| "keras-core", | |||
| "kagglehub", | |||
| "keras_nlp", | |||
There was a problem hiding this comment.
We will need to swap with keras_nlp_nightly if we are going to do this for nightly package.
There was a problem hiding this comment.
Thinking again, this may be OK to add. But we don't want to add to requirements_common
sampathweb
requested changes
Apr 27, 2024
| @@ -4,6 +4,7 @@ regex | |||
| pandas | |||
| kagglehub | |||
| keras-core>=0.1.6 | |||
| keras_nlp | |||
There was a problem hiding this comment.
We don't want to add to reqirements_common. This will cause other issues since keras_nlp will install TF with it and we may want the GPU version. So lets keep keras_nlp out of requirements file.
|
@VarunS1997 - I needed to cut a release. So wrapped this into #2427. If that's good, we can close this PR? |
|
Agreed with @sampathweb and have approved the other PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2400 by adding the keras_nlp and tensorflow_text dependencies as direct requirements for the keras_cv repo.
Before submitting
Pull Request section?
to it if that's the case.