Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new dependency on keras_nlp #2419

Closed
wants to merge 4 commits into from
Closed

Added new dependency on keras_nlp #2419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbca659
Added new dependency on keras_nlp
VarunS1997 Apr 22, 2024
c5b8e67
Removed TF dependency
VarunS1997 Apr 22, 2024
51211bb
Added dep to setup file
VarunS1997 Apr 23, 2024
00985d4
Update setup.py
VarunS1997 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements-common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ regex
pandas
kagglehub
keras-core>=0.1.6
keras_nlp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to add to reqirements_common. This will cause other issues since keras_nlp will install TF with it and we may want the GPU version. So lets keep keras_nlp out of requirements file.

tensorflow-datasets
pycocotools
# Tooling deps.
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def is_pure(self):
"tensorflow-datasets",
"keras-core",
"kagglehub",
"keras_nlp",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to swap with keras_nlp_nightly if we are going to do this for nightly package.

Copy link
Collaborator

@sampathweb sampathweb Apr 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking again, this may be OK to add. But we don't want to add to requirements_common

],
extras_require={
"tests": [
Expand Down
Loading