Disable chaosduck on the webhook

[benmoss]

Serving has done this as well, the chaosduck killing the webhook causes errors being tracked in knative/pkg#1509

ref: knative/serving#8772

Fixes #5416, probably lots of others 😄

[codecov]

Codecov Report

Merging #5419 (71b95b8) into main (453e4c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5419   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         194      194           
  Lines        5987     5987           
=======================================
  Hits         4947     4947           
  Misses        717      717           
  Partials      323      323           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453e4c0...71b95b8. Read the comment docs.

[pierDipi]

Thanks, one minor comment.

There is another webhook inmemorychannel-webhook :

eventing/config/channels/in-memory-channel/webhooks/resource-validation.yaml

Lines 24 to 26 in 23198cd

	service:
	name: inmemorychannel-webhook
	namespace: knative-eventing

eventing/config/channels/in-memory-channel/webhooks/defaulting.yaml

Lines 24 to 26 in 23198cd

	service:
	name: inmemorychannel-webhook
	namespace: knative-eventing

which points to imc-controller, which is already disabled due to another issue #3590

[dprotaso]

@benmoss can you do me a favour and bump the timeout in a separate PR and see if the flake still occurs after some time

https://github.com/knative/eventing/blob/main/config/core/webhooks/defaulting.yaml#L30

I noticed Istio has their timeout set to 30s.

[benmoss]

weird that we are still seeing EOFs on this PR even, maybe this isn't the fix we need

/test pull-knative-eventing-reconciler-tests

[pierDipi]

/lgtm
/retest

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

/hold

[benmoss]

I had a subtle mistake: "disable=eventing-webhook", was missing the - before disable

[benmoss]

let's run this a few times and see that it seems stable

[pierDipi]

/lgtm

unhold once you're ready to merge this.

[pierDipi]

Worked, retesting
/test pull-knative-eventing-reconciler-tests

[matzew]

@benmoss any comments on Dave's suggestion:
#5419 (comment)

[benmoss]

I don't really understand why increasing the timeout would fix things, it's not a timeout issue but an EOF on an open connection

[benmoss]

/test pull-knative-eventing-reconciler-tests

[benmoss]

/hold cancel