feat: ✨ support for polish language #189
Conversation
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| ## Unreleased | |||
|
|
|||
| ### Features | |||
There was a problem hiding this comment.
This should go under Next below, that's our unreleased.
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module NumbersAndWords | |||
| VERSION = '0.11.12' | |||
| VERSION = '0.11.11' | |||
There was a problem hiding this comment.
This was correct, next version is 0.11.12 and the current code is incremented for that.
I do think we should make next version 0.12.0 since we're adding a whole new language. Please change this and the version in CHANGELOG to 0.12.0.
| end | ||
| end | ||
| end | ||
| # frozen_string_literal: true |
There was a problem hiding this comment.
CR/LF changes - you should probably just revert it, and ensure that new files have unix CR/LF
same for the other two in this directory
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| ## Unreleased | |||
There was a problem hiding this comment.
0.11.12 wasn't released, move your feature to the section below
There was a problem hiding this comment.
Thanks for hanging in here! There's still a couple of changes below that need to be reverted and tests are failing.
https://github.com/kslazarev/numbers_and_words/runs/7460137123?check_suite_focus=true
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module NumbersAndWords | |||
| VERSION = '0.11.12' | |||
| VERSION = '0.11.11' | |||
|
There is still a problem with hundreds and a few other things, maybe it's a configuration issue in the strategies / figures_converter/languages/pl.rb file. I don't know how to solve it, I added some tests with correct examples. Most of the things are practically similar to what in Czech I tried to copy the content from upload to pl.rb but it was throwing me errors.
Maybe with your help I can figure out this problem. |
|
@sectasy0 if you just copy over all of translations/cs.rb onto translations/pl.rb you'll get quite a bit further. At least it will get rid of mechanical errors. Unfortunately I think one needs to speak Polish to properly construct the translation rules around gender/ordinals/etc. |
|
@dblock I'm native polish speaker. All translations are properly constructed in .yml files as well as correct examples. Example with hundreds: |
|
@sectasy0 want to finish this? |
Yeah, but I don't quite understand why it returns all the things, I just copied everything from czech language which is basically the same as in Polish in terms of numbers, wanna help me a little? |
|
I checked out your code and rn all specs pass. Add ones that fail and I can try to take a look? |
I add polish support and some test with correct fixtures examples. I don't know if I did something wrong, polish support works almost fine besides a few cases that I mentioned in Issue.
Closes #189.