Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use f-string in place of old-style formatted string #2124

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore: use f-string in place of old-style formatted string #2124

merged 1 commit into from
Sep 13, 2023

Conversation

Ananya2001-an
Copy link
Member

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

The old-style string formatting in python is somewhat outdated. It's better to use f-strings instead.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 13, 2023
@yliaog
Copy link
Contributor

yliaog commented Sep 13, 2023

/release-note-none

@k8s-ci-robot
Copy link
Contributor

@yliaog: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yliaog
Copy link
Contributor

yliaog commented Sep 13, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ananya2001-an, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@yliaog
Copy link
Contributor

yliaog commented Sep 13, 2023

/release-note-none

@k8s-ci-robot
Copy link
Contributor

@yliaog: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yliaog yliaog removed the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Sep 13, 2023
@yliaog
Copy link
Contributor

yliaog commented Sep 13, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 74453c9 into kubernetes-client:master Sep 13, 2023
10 checks passed
@Ananya2001-an Ananya2001-an deleted the chore-format-string branch September 13, 2023 19:13
@Ananya2001-an Ananya2001-an mentioned this pull request Oct 5, 2023
Merged
@Ananya2001-an Ananya2001-an mentioned this pull request Oct 14, 2023
Closed
9 tasks
dirrao pushed a commit to dirrao/python that referenced this pull request Nov 28, 2023
@k8s-ci-robot
Merge pull request kubernetes-client#2124 from Ananya2001-an/chore-fo…
a4a7b37 
…rmat-string

chore: use f-string in place of old-style formatted string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ananya2001-an @yliaog @k8s-ci-robot