Move file share lib to azurefile project #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
MartinForReal
force-pushed
the
shafan/mgmtclient
branch
from
ceec17e
to
ffce2a8
Compare
Signed-off-by: Fan Shang Xiang <[email protected]>
k8s-ci-robot
added
the
needs-rebase
MartinForReal
force-pushed
the
shafan/mgmtclient
branch
from
ffce2a8
to
20a95f8
Compare
k8s-ci-robot
removed
the
needs-rebase
MartinForReal
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
MartinForReal
force-pushed
the
shafan/mgmtclient
branch
2 times, most recently
from
3cdcd26
to
83a8dd8
Compare
MartinForReal
force-pushed
the
shafan/mgmtclient
branch
from
83a8dd8
to
80b1159
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Refactor management clients libs and move related code to azurefile project
implement new fileshare client using track2 management client
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: