Make synchronizer hybrid ESM/CJS package #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f492b1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
devcatalin
previously approved these changes
Aug 23, 2023
4 tasks
f1ames
force-pushed
the
f1ames/refactor/build
branch
from
f9b97dd
to
f492b1d
Compare
devcatalin
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #479 and fixes #486.
There were some issue with importing
synchronizerpackage in Desktop and VSC and we tried different approaches with @devcatalin. This fixes it for desktop and doesn't break for VSC.Changes
@monokle/typespackage, as before dependency onvalidationwas causing some issues for import in VSC (see feat(validation): make validation ESM/CJS package [WIP] #479 (comment)).Fixes
Checklist