-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/submission cross referencing #575
Draft
cecemel
wants to merge
68
commits into
development
Choose a base branch
from
feature/submission-cross-referencing
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-article-types Added extra code list: ArticleType
@Windvis, since you'll be working on the custom component, don't forget to add the triples it saves and loads as "hidden" fields in the form.
|
This makes testing easier. PR: lblod/frontend-loket#391
This updates the form to the state from this PR: lblod/manage-submission-form-tooling#52
With this config, all the data for the Submission, SubmissionDocument, FormData and Artikel are included in the Vendor Graphs.
This was referenced Jun 27, 2024
Merged
Co-authored-by: Riad Abdallah <[email protected]>
Feature/lmb cutover
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be the overarching PR integrating the cross-referencing functionality for worship decisions.
See also: DL-5814 and analysis: link to analysis
Current State dd. 2024-07-10
General
Previous state (keeping it for archive)
Worship Decisions Cross-Reference Service [DL-5903]
https://github.com/lblod/worship-decisions-cross-reference-service/blob/master/query-utils.js#L114
Testing
The painful way
Create submissions first with
Bestuur van de eredienst Kerkfabriek St.-Martinus van Aalst
(and send these).-> See the mapping to understand what maps to what: Mapping Spreadsheet.
Then log in with
Gemeente Aalst
. It's best to play with your browser's XHR-edit calls function, as you'll have everything at hand to just make it work.Then, send a GET request with, for example, the following parameters:
http://localhost:4205/related-document-information?forDecisionType=https://data.vlaanderen.be/id/concept/BesluitType/79414af4-4f57-4ca3-aaa4-f8f1e015e71c&forEenheid=http://data.lblod.info/id/besturenVanDeEredienst/a51f65ab7b245dfa76e9698bd5e0f20
That should yield a
text/turtle
with data if you correctly created the submissions.The easy way
To run together with lblod/frontend-loket#391
Create submissions first with
Bestuur van de eredienst Kerkfabriek St.-Martinus van Aalst
(and send these).-> See the mapping to understand what maps to what: Mapping Spreadsheet.
Then log in with
Gemeente Aalst
. The select the type dossiers according to the mapping table.Extra code list added: Article Types [DL-5865]
Extra code list has been added
Testing
The painful way
To test this, see lblod/enrich-submission-service#20
The easy way
To run together with lblod/frontend-loket#391 Login as a
Gemeente
and select a type dossier:Advies jaarrekening eredienstbestuur
and the codelist should eventually appear.Extract
besluit:Artikel
[DL-5868]Updated
toezicht-flattened-form-data-generator
to extractbesluit:Artikel
fromform-data.ttl
See: lblod/toezicht-flattened-form-data-generator#10
RC-version added in this PR
Testing
To run together with lblod/frontend-loket#391 Login as a
Gemeente
and select a type dossier:Advies jaarrekening eredienstbestuur
.Check the triples in the database
Extend prepared-submission-for-export [DL-5869]
See: lblod/prepare-submissions-for-export-service#14
RC-version added in this PR
Testing
To run together with lblod/frontend-loket#391 Login as a
Gemeente
and select a type dossier:Advies jaarrekening eredienstbestuur
.Check the triples in the database, after having sent the dossier.
Extend delta-producer-configuration [DL-5870]
Extended delta-poducer-configuratoin
Testing
To run together with lblod/frontend-loket#391 Login as a
Gemeente
and select a type dossier:Advies jaarrekening eredienstbestuur
.Delta files should appear , after having sent the dossier.
Updated forms [DL-5867]
The forms were updated. See: lblod/manage-submission-form-tooling#50
Testing
To run together with lblod/frontend-loket#391
You will see the component popping up when selecting the relevant dossiers. Note; you don't need to apply the patch anymore described in the PR