Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/submission cross referencing #575

Draft
wants to merge 68 commits into
base: development
Choose a base branch
from

Conversation

cecemel
Copy link
Member

@cecemel cecemel commented May 23, 2024

This PR will be the overarching PR integrating the cross-referencing functionality for worship decisions.
See also: DL-5814 and analysis: link to analysis

Current State dd. 2024-07-10

General

Previous state (keeping it for archive)

Worship Decisions Cross-Reference Service [DL-5903]

Testing

The painful way

Create submissions first with Bestuur van de eredienst Kerkfabriek St.-Martinus van Aalst (and send these).

-> See the mapping to understand what maps to what: Mapping Spreadsheet.

Then log in with Gemeente Aalst. It's best to play with your browser's XHR-edit calls function, as you'll have everything at hand to just make it work.

Then, send a GET request with, for example, the following parameters:

http://localhost:4205/related-document-information?forDecisionType=https://data.vlaanderen.be/id/concept/BesluitType/79414af4-4f57-4ca3-aaa4-f8f1e015e71c&forEenheid=http://data.lblod.info/id/besturenVanDeEredienst/a51f65ab7b245dfa76e9698bd5e0f20

That should yield a text/turtle with data if you correctly created the submissions.

The easy way

To run together with lblod/frontend-loket#391

Create submissions first with Bestuur van de eredienst Kerkfabriek St.-Martinus van Aalst (and send these).

-> See the mapping to understand what maps to what: Mapping Spreadsheet.

Then log in with Gemeente Aalst. The select the type dossiers according to the mapping table.

Extra code list added: Article Types [DL-5865]

Extra code list has been added

Testing

The painful way

To test this, see lblod/enrich-submission-service#20

The easy way

To run together with lblod/frontend-loket#391 Login as a Gemeente and select a type dossier: Advies jaarrekening eredienstbestuur and the codelist should eventually appear.

Extract besluit:Artikel [DL-5868]

Updated toezicht-flattened-form-data-generator to extract besluit:Artikel from form-data.ttl
See: lblod/toezicht-flattened-form-data-generator#10
RC-version added in this PR

Testing

To run together with lblod/frontend-loket#391 Login as a Gemeente and select a type dossier: Advies jaarrekening eredienstbestuur.
Check the triples in the database

Extend prepared-submission-for-export [DL-5869]

See: lblod/prepare-submissions-for-export-service#14
RC-version added in this PR

Testing

To run together with lblod/frontend-loket#391 Login as a Gemeente and select a type dossier: Advies jaarrekening eredienstbestuur.
Check the triples in the database, after having sent the dossier.

Extend delta-producer-configuration [DL-5870]

Extended delta-poducer-configuratoin

Testing

To run together with lblod/frontend-loket#391 Login as a Gemeente and select a type dossier: Advies jaarrekening eredienstbestuur.
Delta files should appear , after having sent the dossier.

Updated forms [DL-5867]

The forms were updated. See: lblod/manage-submission-form-tooling#50

Testing

To run together with lblod/frontend-loket#391
You will see the component popping up when selecting the relevant dossiers. Note; you don't need to apply the patch anymore described in the PR

@cecemel cecemel marked this pull request as draft May 23, 2024 11:55
@cecemel
Copy link
Member Author

cecemel commented May 27, 2024

@Windvis, since you'll be working on the custom component, don't forget to add the triples it saves and loads as "hidden" fields in the form.

fields:has_part a form:Field ;
    sh:name "TEST" ;
    sh:order 1001 ;
    sh:path <http://data.europa.eu/eli/ontology#has_part>;
    sh:group fields:aDynamicPropertyGroup .

fields:type a form:Field ;
    sh:name "TEST" ;
    sh:order 1001 ;
    sh:path (<http://data.europa.eu/eli/ontology#has_part> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type>);
    sh:group fields:aDynamicPropertyGroup .

fields:type_doc a form:Field ;
    sh:name "TEST" ;
    sh:order 1001 ;
    sh:path (<http://data.europa.eu/eli/ontology#has_part> <http://data.europa.eu/eli/ontology#type_document>);
    sh:group fields:aDynamicPropertyGroup .

fields:refers_to a form:Field ;
    sh:name "TEST" ;
    sh:order 1001 ;
    sh:path (<http://data.europa.eu/eli/ontology#has_part> <http://data.europa.eu/eli/ontology#refers_to>);
    sh:group fields:aDynamicPropertyGroup .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants