foundations for rating color advantage #598
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before changing the implementation to use the color advantage, the implementer should start with adding tests to test-kit/src/test/scala/rating/glicko/impl/RatingCalculatorWithColorAdvantageTest.scala ```sh sbt project testKit ~testQuick chess.rating.glicko.* ```
ddugovic
added a commit
to ddugovic/scalachess
that referenced
this pull request
Nov 22, 2024
ddugovic
added a commit
to ddugovic/scalachess
that referenced
this pull request
Nov 22, 2024
ddugovic
added a commit
to ddugovic/scalachess
that referenced
this pull request
Nov 22, 2024
ddugovic
added a commit
to ddugovic/scalachess
that referenced
this pull request
Nov 22, 2024
ddugovic
added a commit
to ddugovic/scalachess
that referenced
this pull request
Nov 22, 2024
|
I made an attempt at adding tests #599 |
|
Tests on that attempt PR now demonstrate that the implementation fails to satisfy expectations. I don't know what the exact rating numbers should be, but I do know that the implementation should produce different numbers when calculating with a color advantage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before changing the implementation to use the color advantage, the implementer should start with adding tests to
test-kit/src/test/scala/rating/glicko/GlickoCalculatorWithColorAdvantageTest.scala
@ddugovic here's where to start from. I'll handle the eventual lila integration.