MAINT: Update testing (use Black, Ruff, precommit hook) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use black to autoformat code - swap out flake8 for Ruff for linting - add precommit hook to test for style errors before commiting or pushing - add a pyproject toml file to configure black, ruff, codespell, etc - update github workflows style test
- Black has now autoformatted all files - and remaining flakes have been fixed
- use mne.util. warn to accurately raise warnings
cleaned up, and dropped low correlation assertion for now. commented the github issue number for reference
there is deprecation warning stemming from dash-testing that they need to handle.
trying to ignore the dash testing deprecation warning for now
right now we only test on one OS. In principle we should test with ubuntu, macos, and windows. But lets start with mac so that the testing runner matches the OS that the local devs use
in test_simulated really only EEG 001 and EEG 002 should be flagged because we make them noisy
- there is some error in test_topoViz that needs to be looked into in separate PR
the test_simulated file is very short, approx 20 seconds. So a few epochs with blinks will be outliers and accont for more than 20 percent of total epochs, causing the channel to be flagged. Raise the flag_crit to 30 percent to be more liberal so that blinks in a channel to cause it to be flagged
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
===========================================
+ Coverage 22.65% 77.63% +54.97%
===========================================
Files 7 12 +5
Lines 565 921 +356
===========================================
+ Hits 128 715 +587
+ Misses 437 206 -231
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
to open the built docs, path should end with .html not .rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to tighten up the screws. Let's see what breaks.