Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update testing (use Black, Ruff, precommit hook) #140

Merged
merged 18 commits into from
Sep 15, 2023
Merged

MAINT: Update testing (use Black, Ruff, precommit hook) #140

merged 18 commits into from
Sep 15, 2023

Commits on May 1, 2023

  1. Configuration menu
    Copy the full SHA
    d78fbc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    1e91cc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. MAINT: update testing requirements and configuration

    - Use black to autoformat code
    - swap out flake8 for Ruff for linting
    - add precommit hook to test for style errors before commiting or pushing
    - add a pyproject toml file to configure black, ruff, codespell, etc
    - update github workflows style test
    scott-huberty committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    6bda883 View commit details
    Browse the repository at this point in the history
  2. MAINT, STY: reformat all files with Black

    - Black has now autoformatted all files
    - and remaining flakes have been fixed
    scott-huberty committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    718a485 View commit details
    Browse the repository at this point in the history
  3. TST: Error on warnings in CI, fix warnings in code

    - use mne.util. warn to accurately raise warnings
    scott-huberty committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    256c38f View commit details
    Browse the repository at this point in the history
  4. TST: update test_simulated

    cleaned up, and dropped low correlation assertion for now. commented the github issue number for reference
    scott-huberty committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    faa6948 View commit details
    Browse the repository at this point in the history
  5. TST: error in linting setup and deprecation warning

    there is deprecation warning stemming from dash-testing that they need to handle.
    scott-huberty committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1817512 View commit details
    Browse the repository at this point in the history
  6. TST: fix pytest config

    trying to ignore the dash testing deprecation warning for now
    scott-huberty committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b9627f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    91a6518 View commit details
    Browse the repository at this point in the history
  2. TST: use macos runner instead of ubuntu

    right now we only test on one OS. In principle we should test with ubuntu, macos, and windows.
    
    But lets start with mac so that the testing runner matches the OS that the local devs use
    scott-huberty committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5fa69c4 View commit details
    Browse the repository at this point in the history
  3. TST: adjust config kwargs

    in test_simulated really only EEG 001 and EEG 002 should be flagged because we make them noisy
    scott-huberty committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5ca3c73 View commit details
    Browse the repository at this point in the history
  4. TST, FIX: mark test_topoViz as failing

    - there is some error in test_topoViz that needs to be looked into in separate PR
    scott-huberty committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6a4811f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a18ff8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    afc29ba View commit details
    Browse the repository at this point in the history
  7. TST: raise flag_crit in test_simulated

    the test_simulated file is very short, approx 20 seconds. So a few epochs with blinks will be outliers and accont for more
    than 20 percent of total epochs, causing the channel to be flagged. Raise the flag_crit to 30 percent to be more liberal so that blinks in a channel to cause it to be flagged
    scott-huberty committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b997a0a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    cbeef41 View commit details
    Browse the repository at this point in the history
  2. DOC, FIX: fixed instructions to build docs locally

    to open the built docs, path should end with .html not .rst
    scott-huberty committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    1597e36 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c257c0e View commit details
    Browse the repository at this point in the history