Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Windows, Linux, MacOS Intel #169

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

scott-huberty
Copy link
Member

This makes sure we test our CI's on the major platforms (Linux, Windows, macOS). For macOS we are testing arm64 and Intel.

I suspect we may see a bug with installing pylossless on windows that users have been reporting.

I think that a character encoding error in the README is causing the error on windows.
@scott-huberty
Copy link
Member Author

The Windows install bug fix was simply to explicitly specify the character encoding when reading the README.md (On windows I think the default encoding isn't UTF-8).

We should probably always explicitly specify the encoding when reading files anyways... But for installation I think an even better fix might be to switch from the requirements.txt / setup.py combo to the more modern pyproject.toml.

Once CI's are green (fingers crossed! 🤞 ), @christian-oreilly I'll merge tomorrow if I don't receive an approval or request for changes.

I think the issues is that torch dropped support for macOS Intel upon release of 2.3. And torch < 2.3 doesnt play well with Numpy 2. So the fix here is to downgrade numpy versions to 1 for macOS Intel only.
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.03%. Comparing base (5f2c341) to head (c670dd1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   73.03%   73.03%           
=======================================
  Files          22       22           
  Lines        1157     1157           
=======================================
  Hits          845      845           
  Misses        312      312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scott-huberty
Copy link
Member Author

FYI we hit some warnings when testing our pipeline with the MacOS Intel VM. It was just a dependency conflict.

The issue is that PyTorch stopped supporting MacOS Intel machines upon release of 2.3 I believe. So torch 2.2.* gets installed on the MacOS Intel VM, which doesn't play with with Numpy 2!. So the patch is to downgrade to Numpy 1 On the MacOS Intel VM only.

But since they were just warnings anyways (no errors!), I think I might just add something to the documentation to hint to any other MacOS Intel users out there, that if they care about suppressing these warnings, they should be able to safely downgrade to Numpy 1.

Leaving this here because both I and @christian-oreilly have Intel Macs 🙂

@scott-huberty scott-huberty merged commit 8598b63 into lina-usc:main Oct 3, 2024
6 checks passed
@scott-huberty scott-huberty deleted the test_major_os branch October 3, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant