Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check column exists in NestedFrame.__setitem__ #173

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Nov 6, 2024

Fixes bug introduced during the changes to support non-unique indices.

@hombit hombit requested a review from wilsonbb November 6, 2024 22:27
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.40%. Comparing base (96503cd) to head (1f86e14).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          14       14           
  Lines        1003     1004    +1     
=======================================
+ Hits          997      998    +1     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 6, 2024

Before [96503cd] <v0.3.0> After [028c457] Ratio Benchmark (Parameter)
22.4±0.6ms 23.0±0.8ms 1.03 benchmarks.AssignSingleDfToNestedSeries.time_run
31.3±8ms 31.8±5ms 1.02 benchmarks.ReassignHalfOfNestedSeries.time_run
266M 266M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
88.4M 88.2M 1 benchmarks.NestedFrameAddNested.peakmem_run
9.20±0.1ms 9.18±0.1ms 1 benchmarks.NestedFrameAddNested.time_run
93.4M 93.2M 1 benchmarks.NestedFrameQuery.peakmem_run
7.91±0.1ms 7.92±0.1ms 1 benchmarks.NestedFrameQuery.time_run
91.8M 91.8M 1 benchmarks.NestedFrameReduce.peakmem_run
285M 285M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
1.61±0.02ms 1.53±0.01ms 0.95 benchmarks.NestedFrameReduce.time_run

Click here to view all benchmarks.

@wilsonbb wilsonbb merged commit 402ab66 into main Nov 6, 2024
10 checks passed
@wilsonbb wilsonbb deleted the setitem-missed-column branch November 6, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants