Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port pandas-ts code #2

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Port pandas-ts code #2

merged 2 commits into from
Apr 3, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Apr 3, 2024 •
edited
Loading

@hombit hombit marked this pull request as ready for review April 3, 2024 16:22
@hombit hombit requested a review from dougbrn April 3, 2024 16:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

Before [05cc195] After [ca7c83a] Ratio Benchmark (Parameter)
3.27±1s 1.09±1s ~0.33 benchmarks.time_computation
4.01k 2.38k 0.59 benchmarks.mem_list

Click here to view all benchmarks.

dougbrn
dougbrn approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read through this a few times, I don't fully grasp every detail yet, but nothing stood out to me as obviously problematic. Just had one nit on a test name

tests/nested_pandas/series/test_accessor.py Outdated Show resolved Hide resolved
@hombit hombit merged commit 05cc195 into main Apr 3, 2024
7 checks passed
@hombit hombit deleted the port-pandas-ts branch April 4, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbrn dougbrn dougbrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hombit @dougbrn