-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint to download a certificate value #2074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on Graphite |
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
3 times, most recently
from
May 29, 2024 13:20
14fd1b2
to
5915829
Compare
graphite-app
bot
requested review from
afck,
MathieuDutSik,
christos-h,
ma2bd,
jvff and
Twey
May 29, 2024 14:28
Graphite Automations"Assign reviewers" took an action on this PR • (05/29/24)6 reviewers were added to this PR based on Andre da Silva's automation. |
afck
reviewed
May 29, 2024
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
from
May 29, 2024 23:33
5915829
to
7832aa3
Compare
This was referenced May 29, 2024
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
2 times, most recently
from
May 30, 2024 21:07
c8a3801
to
143c6a4
Compare
ndr-ds
changed the title
GRPC entrypoint to download a certificate
Endpoint to download a certificate value
May 30, 2024
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
3 times, most recently
from
May 31, 2024 02:54
19ddf6b
to
cba62d9
Compare
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
from
May 31, 2024 15:30
cba62d9
to
7a20c90
Compare
This was referenced May 31, 2024
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
from
June 1, 2024 03:21
7a20c90
to
eded29e
Compare
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
from
June 13, 2024 17:28
eded29e
to
cacd182
Compare
afck
reviewed
Jun 15, 2024
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
from
June 17, 2024 07:11
cacd182
to
c1b9285
Compare
afck
reviewed
Jun 17, 2024
afck
reviewed
Jun 17, 2024
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
2 times, most recently
from
June 17, 2024 16:06
bb19397
to
ca5a8ab
Compare
afck
approved these changes
Jun 17, 2024
ndr-ds
force-pushed
the
05-28-grpc_entrypoint_to_download_a_certificate
branch
from
June 17, 2024 22:15
ca5a8ab
to
25c740e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to be able to download certificate values directly from the Proxy. Fixes #2029
Proposal
Adds an entrypoint for downloading a certificate value given a hash
Test Plan
CI for now, will replace chain info queries in following PR