Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificate -> HandleCertificateRequest on rpc.proto #2084

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Certificate -> HandleCertificateRequest on rpc.proto #2084

merged 1 commit into from
Jun 18, 2024

Conversation

ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented May 30, 2024

Motivation

The current proto struct is called Certificate, but it isn't really representing that

Proposal

Rename it to what it actually represents

Test Plan

CI

This was referenced May 30, 2024
Merged
Closed
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented May 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on Graphite Graphite

@ndr-ds ndr-ds mentioned this pull request May 30, 2024
Merged
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from e145d6d to 9d817ad Compare May 30, 2024 21:14
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 210bc99 to 82ac394 Compare May 30, 2024 21:20
@ndr-ds ndr-ds marked this pull request as ready for review May 30, 2024 21:25
@graphite-app Graphite App
Copy link

graphite-app bot commented May 30, 2024

Graphite Automations

"Assign reviewers" took an action on this PR • (05/30/24)

6 reviewers were added to this PR based on Andre da Silva's automation.

@ndr-ds ndr-ds changed the title Certificate -> HandleCertificateRequest on rpc.proto Certificate -> CertificateRequest on rpc.proto May 31, 2024
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 9d817ad to a803404 Compare May 31, 2024 02:29
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 82ac394 to 98c2be1 Compare May 31, 2024 02:29
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from a803404 to 056ad62 Compare May 31, 2024 02:36
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 98c2be1 to b720a27 Compare May 31, 2024 02:36
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 056ad62 to fca41fc Compare May 31, 2024 02:56
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from b720a27 to 750f121 Compare May 31, 2024 02:56
@ndr-ds ndr-ds mentioned this pull request May 31, 2024
Closed
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from fca41fc to 6924a6f Compare May 31, 2024 15:30
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 750f121 to 4a162e3 Compare May 31, 2024 15:31
This was referenced May 31, 2024
Closed
Merged
Merged
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 6924a6f to 22df812 Compare June 1, 2024 03:23
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 4a162e3 to 799fea5 Compare June 1, 2024 03:23
afck
afck reviewed Jun 1, 2024
View reviewed changes
linera-rpc/proto/rpc.proto Outdated Show resolved Hide resolved
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch 2 times, most recently from 583b56e to d60e1f5 Compare June 17, 2024 07:28
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 799fea5 to cfc02e1 Compare June 17, 2024 07:55
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from d60e1f5 to c69c426 Compare June 17, 2024 12:18
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from cfc02e1 to 1db0249 Compare June 17, 2024 12:19
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from c69c426 to 46e0874 Compare June 17, 2024 16:09
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 1db0249 to 788257e Compare June 17, 2024 16:09
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 46e0874 to 943c64d Compare June 18, 2024 08:03
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 788257e to 78b02e1 Compare June 18, 2024 08:10
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch 2 times, most recently from 20f4628 to 6c79a85 Compare June 18, 2024 09:55
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 78b02e1 to d8f42ed Compare June 18, 2024 09:57
@ndr-ds ndr-ds force-pushed the 05-29-replace_certificate_chain_info_query_usage_with_certificate_download branch from 6c79a85 to 340b0a1 Compare June 18, 2024 11:13
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from d8f42ed to 26ffd08 Compare June 18, 2024 11:14
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Jun 18, 2024 •
edited
Loading

Merge activity

  • Jun 18, 8:14 AM EDT: @andresilva91 started a stack merge that includes this pull request via Graphite.
  • Jun 18, 8:16 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 18, 8:17 AM EDT: @andresilva91 merged this pull request with Graphite.

Base automatically changed from 05-29-replace_certificate_chain_info_query_usage_with_certificate_download to main June 18, 2024 12:15
@ndr-ds ndr-ds force-pushed the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch from 26ffd08 to 27263d2 Compare June 18, 2024 12:15
@ndr-ds ndr-ds merged commit 13115d8 into main Jun 18, 2024
4 checks passed
@ndr-ds ndr-ds deleted the 05-30-certificate_-_handlecertificaterequest_on_rpc.proto branch June 18, 2024 12:17
@ndr-ds ndr-ds linked an issue Jun 18, 2024 that may be closed by this pull request
Simplify chain info queries and always use separate GRPC queries to download blobs and certificates #2072
Closed
@ndr-ds ndr-ds changed the title Certificate -> CertificateRequest on rpc.proto Certificate -> HandleCertificateRequest on rpc.proto Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuDutSik MathieuDutSik MathieuDutSik left review comments

@afck afck afck approved these changes

@Twey Twey Awaiting requested review from Twey

@christos-h christos-h Awaiting requested review from christos-h

@ma2bd ma2bd Awaiting requested review from ma2bd

@jvff jvff Awaiting requested review from jvff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify chain info queries and always use separate GRPC queries to download blobs and certificates
3 participants
@ndr-ds @MathieuDutSik @afck