Remove retry loop from make_application.

[afck]

This should make the end-to-end tests less flaky and slightly faster by making sure cross-chain messages have been processed when the test observes the result.

Motivation

Suppose an application is registered on chain A:

• If chain B requests that application from chain A, we have to wait for
  • chain A to process the request, and
  • chain B to process the response…
• If chain A sends an application message to chain B, we have to wait for
  • chain B to process the message…

…before we can expect the application to be registered on chain B.

In the tests, we currently just retry in a loop until this has happened.

Proposal

Call process_inbox in the right places, and remove the retry loop.

Test Plan

All affected tests run in CI.

Links

• reviewer checklist