Check storage in get_blobs #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on |
This was referenced Oct 11, 2024
afck
approved these changes
Oct 14, 2024
ndr-ds
force-pushed
the
10-11-check_storage_in_get_blobs
branch
from
bbd1c45
to
07bc3cf
Compare
ndr-ds
changed the base branch from
10-11-clean_up_left_over_bytecode_code
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
get_blobsis used when we process confirmed blocks, so it's actually wrong to not check storage here.Proposal
Check storage also when searching for the blobs.
Test Plan
CI but this will also be more triggered in following PRs
Release Plan