Create ApplicationDescription blob type #2612

ndr-ds · 2024-10-12T05:56:37Z

Motivation

We need a new ApplicationDescription blob type

Proposal

Add the blob type, but don't use it yet.

Test Plan

CI

Release Plan

Nothing to do / These changes follow the usual release cycle.

ndr-ds · 2024-10-12T05:56:55Z

Remove application registry #2650
Use ApplicationDescription blob type #2647
Create ApplicationDescription blob type #2612 👈 (View in Graphite)
Get rid of get_blobs_not_found and unify blob errors #2649
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

afck · 2024-10-15T09:56:19Z

linera-base/src/data_types.rs

-    pub fn new_data(bytes: Vec<u8>) -> Self {
-        BlobContent::new_data(bytes).into()
+    pub fn new_data(bytes: Vec<u8>) -> Result<Self, bcs::Error> {
+        BlobContent::new_data(bytes).try_into()


That really can't fail, can it? Would it make sense to expect here? (And in the other methods that can't fail?)
Or even inline the relevant part of the implementation, so the Result doesn't show up in the first place?

Yes, if it fails, something is very wrong 😅 so it might make sense to panic. I'll change it!

afck

Approving, but maybe let's wait with merging this until the follow-up PR is also approved, so we don't have those duplicated types on main for too long.

afck · 2024-10-22T09:34:51Z

linera-execution/src/lib.rs

@@ -142,6 +142,8 @@ pub enum ExecutionError {
    JoinError(#[from] linera_base::task::Error),
    #[error(transparent)]
    DecompressionError(#[from] DecompressionError),
+    #[error(transparent)]
+    BcsError(#[from] bcs::Error),


Is there a reason for moving this?

I think I removed it then added it somewhere else by accident as the PR evolved. Will fix

afck · 2024-10-22T09:36:22Z

linera-core/src/client/mod.rs

+        let mut blobs = Vec::new();
+        for byte_vec in bytes {
+            blobs.push(Blob::new_data(byte_vec));
+        }


Suggested change

let mut blobs = Vec::new();

for byte_vec in bytes {

blobs.push(Blob::new_data(byte_vec));

}

let blobs = bytes.into_iter().map(Blob::new_data).collect::<Vec<_>>();

would allocate the right vector size right away.

afck · 2024-11-07T15:00:06Z

linera-core/src/client/mod.rs

+        let mut blobs = Vec::with_capacity(bytes.len());
+        for byte_vec in bytes {
+            blobs.push(Blob::new_data(byte_vec));
+        }


(Maybe more concise?)

Suggested change

let mut blobs = Vec::with_capacity(bytes.len());

for byte_vec in bytes {

blobs.push(Blob::new_data(byte_vec));

}

let blobs = bytes.into_iter().map(Blob::new_data).collect::<Vec<_>>();

afck · 2024-11-07T15:01:57Z

linera-base/src/data_types.rs

+    pub creator_chain_id: ChainId,
+    /// Height of the block that created this application.
+    pub block_height: BlockHeight,
+    /// At what efffect index of the block this application was created.


Suggested change

/// At what efffect index of the block this application was created.

/// At what effect index of the block this application was created.

afck · 2024-11-07T15:07:59Z

linera-base/src/identifiers.rs

+
+impl<A: Ord> Ord for BlobApplicationId<A> {
+    fn cmp(&self, other: &Self) -> std::cmp::Ordering {
+        (self.application_description_hash, self.bytecode_id)


If we destructure in these methods, the compiler will warn us in case we add any additional fields.

afck · 2024-11-07T15:14:45Z

linera-base/src/data_types.rs

    /// Loads data blob content from a file.
-    pub async fn load_data_blob_from_file(path: impl AsRef<Path>) -> io::Result<Self> {
+    pub async fn load_data_blob_from_file(path: impl AsRef<Path>) -> Result<Self, io::Error> {


This was referenced Oct 12, 2024

Miscellaneous fixes in AMM README #2606

Merged

Clean up left over Bytecode code + some related testing fixes #2607

Merged

Check storage in get_blobs #2609

Merged

Return multiple blobs not found at once #2610

Merged

ndr-ds mentioned this pull request Oct 12, 2024

Introduce blob_bytes function #2611

Merged

ndr-ds force-pushed the 10-11-introduce_blob_bytes_function branch 2 times, most recently from dccbffc to 1edf821 Compare October 14, 2024 15:01

Base automatically changed from 10-11-introduce_blob_bytes_function to main October 14, 2024 15:02

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch 2 times, most recently from 58ee530 to ea2a259 Compare October 14, 2024 19:04

ndr-ds changed the base branch from main to 10-11-return_multiple_blobs_not_found_at_once October 14, 2024 19:04

ndr-ds marked this pull request as ready for review October 14, 2024 21:41

ndr-ds requested review from afck, jvff and ma2bd October 14, 2024 21:41

afck reviewed Oct 15, 2024

View reviewed changes

afck approved these changes Oct 15, 2024

View reviewed changes

ndr-ds mentioned this pull request Oct 15, 2024

Make sure our test features depend on their dependencies test features #2627

Merged

ndr-ds force-pushed the 10-11-return_multiple_blobs_not_found_at_once branch from 73f3541 to cd0f531 Compare October 16, 2024 00:59

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch 2 times, most recently from 91372cb to 7fb263d Compare October 16, 2024 01:20

ndr-ds force-pushed the 10-11-return_multiple_blobs_not_found_at_once branch from cd0f531 to 18622a1 Compare October 16, 2024 03:24

Base automatically changed from 10-11-return_multiple_blobs_not_found_at_once to main October 16, 2024 03:26

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch from 7fb263d to b3b01c9 Compare October 16, 2024 03:26

ndr-ds linked an issue Oct 17, 2024 that may be closed by this pull request

Replace ApplicationDescription by blobs #2167

Open

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch from b3b01c9 to f8b54d6 Compare October 18, 2024 02:46

ndr-ds mentioned this pull request Oct 18, 2024

Use ApplicationDescription blob type #2647

Open

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch from f8b54d6 to 38bd265 Compare October 18, 2024 20:31

ndr-ds changed the base branch from main to 10-18-blobnotfoundonread_-_blobsnotfound October 18, 2024 20:31

This was referenced Oct 18, 2024

Get rid of get_blobs_not_found and unify blob errors #2649

Merged

Remove application registry #2650

Open

afck reviewed Oct 22, 2024

View reviewed changes

ndr-ds force-pushed the 10-18-blobnotfoundonread_-_blobsnotfound branch from b49501f to 78912fd Compare October 23, 2024 12:23

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch from 38bd265 to e7a9b98 Compare October 23, 2024 12:29

ndr-ds force-pushed the 10-18-blobnotfoundonread_-_blobsnotfound branch from 78912fd to bb341a0 Compare October 23, 2024 13:19

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch from e7a9b98 to ae67606 Compare October 23, 2024 13:26

ndr-ds force-pushed the 10-18-blobnotfoundonread_-_blobsnotfound branch from bb341a0 to 84566e6 Compare November 5, 2024 21:47

ndr-ds added 2 commits November 6, 2024 21:01

BlobNotFoundOnRead -> BlobsNotFound

ca23cb5

Create ApplicationDescription blob type

7abc4b3

ndr-ds force-pushed the 10-18-blobnotfoundonread_-_blobsnotfound branch from 84566e6 to ca23cb5 Compare November 7, 2024 00:08

ndr-ds force-pushed the 10-12-create_applicationdescription_blob_type branch from ae67606 to 7abc4b3 Compare November 7, 2024 02:01

afck reviewed Nov 7, 2024

View reviewed changes

ndr-ds force-pushed the 10-18-blobnotfoundonread_-_blobsnotfound branch 3 times, most recently from e9a3222 to b550792 Compare November 13, 2024 19:13

ndr-ds changed the base branch from 10-18-blobnotfoundonread_-_blobsnotfound to graphite-base/2612 November 13, 2024 20:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create ApplicationDescription blob type #2612

Create ApplicationDescription blob type #2612

ndr-ds commented Oct 12, 2024 •

edited

Loading

ndr-ds commented Oct 12, 2024 •

edited

Loading

afck Oct 15, 2024 •

edited

Loading

ndr-ds Oct 15, 2024

afck left a comment

afck Oct 22, 2024

ndr-ds Oct 23, 2024

afck Oct 22, 2024

afck Nov 7, 2024

afck Nov 7, 2024

afck Nov 7, 2024

afck Nov 7, 2024

	/// At what efffect index of the block this application was created.
	/// At what effect index of the block this application was created.

Create ApplicationDescription blob type #2612

Are you sure you want to change the base?

Create ApplicationDescription blob type #2612

Conversation

ndr-ds commented Oct 12, 2024 • edited Loading

Motivation

Proposal

Test Plan

Release Plan

ndr-ds commented Oct 12, 2024 • edited Loading

afck Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndr-ds commented Oct 12, 2024 •

edited

Loading

ndr-ds commented Oct 12, 2024 •

edited

Loading

afck Oct 15, 2024 •

edited

Loading