Make sure our test features depend on their dependencies test features #2627
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on |
| "tokio/macros", | ||
| "linera-base/test", | ||
| "linera-execution/test", | ||
| "linera-views/test", |
There was a problem hiding this comment.
Why is that a problem if we don't use the testing library of linera-views ?
There was a problem hiding this comment.
Since we run cargo check-all-features in our CI, if I add a test only function to a trait for example on linera-views, when cargo check-all-features tries to check linera-chain compiled with the test feature, it will think that the test implementation of the function is missing in linera-views. That happens because linera-chain's test feature doesn't include linera-views's test feature, so the test implementation will be seen as test by linera-views but not by linera-chain, so CI will fail.
This happened here: #2607 (comment)
So I figured we might as well fix this for all dependencies already
ndr-ds
force-pushed
the
10-15-make_sure_our_test_features_depend_on_their_dependencies_test_features
branch
2 times, most recently
from
21039cc
to
c9d5cae
Compare
ndr-ds
force-pushed
the
10-15-make_sure_our_test_features_depend_on_their_dependencies_test_features
branch
from
c9d5cae
to
11d2544
Compare
ndr-ds
deleted the
10-15-make_sure_our_test_features_depend_on_their_dependencies_test_features
branch
) ## Motivation The docs test is failing on main ## Proposal Revert #2627 to take a different approach on this: if we change how we're using `add_blob`, we don't need to change any dependencies! ## Test Plan CI + I ran `test_publish.sh` locally and it succeeds ## Release Plan - Nothing to do / These changes follow the usual release cycle.
Motivation
Currently our
testfeatures are not necessarily depending on thetestfeatures from the crate's dependenciesProposal
Fix that and make sure our
testfeature depends on thetestfeature from our dependenciesTest Plan
CI
Release Plan