Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the test-X for the storages. #2699

Closed

Conversation

MathieuDutSik
Copy link
Contributor

Motivation

It is preferable to separate the storage support from their usage.

Proposal

The change being done are:

  • The test-storage-service, test-rocksdb, test-dynamodb, test-scylladb and test-indexeddb are introduced.
  • The selection of test-X automatically implies the selection of X in the Cargo.toml.
  • The CI is updated accordingly.
  • The with_test_dynamodb are added to the build.rs when existing.

Test Plan

The changes do not change the tests.

Release Plan

Not relevant.

Links

@ma2bd
Copy link
Contributor

ma2bd commented Oct 23, 2024

This may not be as urgent or useful because linera net up tries to call linera-storage-server even when the feature storage-service is not selected. Therefore, we don't need to make this feature a default. (In a way, storage-service is already acting as test-storage-service ?)

@MathieuDutSik
Copy link
Contributor Author

We need some more planned changes to the tests and this approach was deemed inadequate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants