Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the json templates more readable #371

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make the json templates more readable #371

wants to merge 3 commits into from

Conversation

daodennis-zz
Copy link
Contributor

Improved formatting so they are easier to edit the first time.

@daodennis-zz
Copy link
Contributor Author

I'm not sure why "Update sarama to support 10.2.1" is showing up again and why there's a conflicting file.

andrewchoi5
andrewchoi5 approved these changes Jan 23, 2020
View reviewed changes
Copy link

@andrewchoi5 andrewchoi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the branch conflicts before merging this pull request. lgtm

andrewchoi5
andrewchoi5 reviewed Feb 11, 2020
View reviewed changes
Copy link

@andrewchoi5 andrewchoi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@andrewchoi5
Copy link

@daodennis-zz Is this PR currently active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewchoi5 andrewchoi5 andrewchoi5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daodennis-zz @andrewchoi5