Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the json templates more readable #371

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make the json templates more readable #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d553e86
Update sarama to support 10.2.1 too.
daodennis-zz Feb 2, 2018
fa42a27
Make slack json templates readable.
daodennis-zz Mar 20, 2018
a2742e9
undo accidental reversal of post/delete tmpls
daodennis-zz Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion config/default-slack-delete.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,30 @@
{ "attachments": [{"color": "good","title": "A kafka consumer is has caught up his lag","fields": [{"title": "Group","value": "{{ .Group }}", "short": false},{"title": "Cluster","value": "{{ .Cluster }}","short": true},{"title": "Total Lag","value": "{{ .Result.TotalLag}}","short": true}, {"title": "Start","value": "{{ .Start.Format "2006-01-02T15:04:05Z07:00" }}","short": true}]}]}
{
"attachments": [
{
"fields": [
{
"short": false,
"value": "{{ .Group }}",
"title": "Group"
},
{
"short": true,
"value": "{{ .Cluster }}",
"title": "Cluster"
},
{
"short": true,
"value": "{{ .Result.TotalLag}}",
"title": "Total Lag"
},
{
"short": true,
"value": " {{ .Start.Format "2006-01-02T15:04:05Z07:00" }}",
"title": "Start"
}
],
"title": "A kafka consumer is no longer lagging",
"color": "good"
}
]
}
31 changes: 30 additions & 1 deletion config/default-slack-post.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,30 @@
{ "attachments": [{"color": "danger","title": "A kafka consumer is lagging behind!","fields": [{"title": "Group","value": "{{ .Group }}", "short": false},{"title": "Cluster","value": "{{ .Cluster }}","short": true},{"title": "Total Lag","value": "{{ .Result.TotalLag}}","short": true}, {"title": "Start","value": "{{ .Start.Format "2006-01-02T15:04:05Z07:00" }}","short": true}]}]}
{
"attachments": [
{
"fields": [
{
"short": false,
"value": "{{ .Group }}",
"title": "Group"
},
{
"short": true,
"value": "{{ .Cluster }}",
"title": "Cluster"
},
{
"short": true,
"value": "{{ .Result.TotalLag}}",
"title": "Total Lag"
},
{
"short": true,
"value": " {{ .Start.Format "2006-01-02T15:04:05Z07:00" }}",
"title": "Start"
}
],
"title": "A kafka consumer is lagging behind!",
"color": "danger"
}
]
}
2 changes: 1 addition & 1 deletion core/internal/helpers/sarama.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func parseKafkaVersion(kafkaVersion string) sarama.KafkaVersion {
return sarama.V0_10_0_1
case "0.10.1", "0.10.1.0":
return sarama.V0_10_1_0
case "", "0.10.2", "0.10.2.0":
case "", "0.10.2", "0.10.2.0", "0.10.2.1":
return sarama.V0_10_2_0
case "0.11.0", "0.11.0.1", "0.11.0.2":
return sarama.V0_11_0_0
Expand Down