Skip to content

Development: Improve git operations performance #61848

Development: Improve git operations performance

Development: Improve git operations performance #61848

Triggered via pull request November 18, 2024 21:55
@SimonEntholzerSimonEntholzer
synchronize #9809
Status Success
Total duration 14s
Artifacts

pullrequest-labeler.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

9 errors
de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest ► usedInProductionCode(): src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleRepositoryArchitectureTest.java#L215
Failed test found in: build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest.xml Error: java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @repository and are declared in classes that should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times):
de.tum.cit.aet.artemis.programming.architecture.ProgrammingServiceArchitectureTest ► testCorrectAsyncCalls(): src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleServiceArchitectureTest.java#L90
Failed test found in: build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.architecture.ProgrammingServiceArchitectureTest.xml Error: java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are annotated with @async should not be called within the same class, because Methods annotated with @async are meant to be executed in a new thread. The thread gets created in a Spring proxy subclass and requires the method to only be called from the outside.' was violated (1 times):
test#L0
Junit Results ran 8413 in 1233.8789999999997 seconds 0 Errored, 3 Failed, 2 Skipped
usedInProductionCode(): /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/architecture/ProgrammingRepositoryArchitectureTest.java#L0
Junit test usedInProductionCode() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @repository and are declared in classes that should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times): Method de.tum.cit.aet.artemis.programming.repository.TemplateProgrammingExerciseParticipationRepository.findWithEagerResultsAndSubmissionsByProgrammingExerciseIdElseThrow(long) is not used in production code
testCorrectAsyncCalls(): /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/architecture/ProgrammingServiceArchitectureTest.java#L0
Junit test testCorrectAsyncCalls() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are annotated with @async should not be called within the same class, because Methods annotated with @async are meant to be executed in a new thread. The thread gets created in a Spring proxy subclass and requires the method to only be called from the outside.' was violated (1 times): Method de.tum.cit.aet.artemis.programming.service.localvc.VcsAccessLogService.saveVcsAccesslog(de.tum.cit.aet.artemis.programming.domain.VcsAccessLog) should not be called from another Async method (LocalVCServletService.java:897)
testNoParticipationWhenPushingToTestsRepository(): /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/icl/LocalCIIntegrationTest.java#L183
Junit test testNoParticipationWhenPushingToTestsRepository() failed java.lang.AssertionError: Expecting actual throwable to be an instance of: de.tum.cit.aet.artemis.core.exception.VersionControlException but was: de.tum.cit.aet.artemis.core.exception.EntityNotFoundException: ProgrammingExerciseStudentParticipation at de.tum.cit.aet.artemis.core.repository.base.RepositoryImpl.lambda$getValueElseThrow$1(RepositoryImpl.java:64) at java.base/java.util.Optional.orElseThrow(Optional.java:403) at de.tum.cit.aet.artemis.core.repository.base.RepositoryImpl.getValueElseThrow(RepositoryImpl.java:64) ...(119 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest ► usedInProductionCode(): src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleRepositoryArchitectureTest.java#L215
Failed test found in: build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest.xml Error: java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @repository and are declared in classes that should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times):
de.tum.cit.aet.artemis.programming.architecture.ProgrammingServiceArchitectureTest ► testCorrectAsyncCalls(): src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleServiceArchitectureTest.java#L90
Failed test found in: build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.architecture.ProgrammingServiceArchitectureTest.xml Error: java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are annotated with @async should not be called within the same class, because Methods annotated with @async are meant to be executed in a new thread. The thread gets created in a Spring proxy subclass and requires the method to only be called from the outside.' was violated (1 times):
de.tum.cit.aet.artemis.programming.icl.LocalCIIntegrationTest ► testNoParticipationWhenPushingToTestsRepository(): src/main/java/de/tum/cit/aet/artemis/core/repository/base/RepositoryImpl.java#L64
Failed test found in: build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.icl.LocalCIIntegrationTest.xml Error: java.lang.AssertionError: