Skip to content

Development: Improve git operations performance #61848

Development: Improve git operations performance

Development: Improve git operations performance #61848

GitHub Actions / Junit Results failed Nov 18, 2024 in 0s

Junit Results

Junit Results ran 8413 in 1233.8789999999997 seconds 0 Errored, 3 Failed, 2 Skipped

Annotations

Check failure on line 0 in test

See this annotation in the file changed.

@github-actions github-actions / Junit Results

test#L0

Junit Results ran 8413 in 1233.8789999999997 seconds 0 Errored, 3 Failed, 2 Skipped

Check failure on line 0 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/architecture/ProgrammingRepositoryArchitectureTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

usedInProductionCode()

Junit test usedInProductionCode() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @Repository and are declared in classes that  should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times):
Method de.tum.cit.aet.artemis.programming.repository.TemplateProgrammingExerciseParticipationRepository.findWithEagerResultsAndSubmissionsByProgrammingExerciseIdElseThrow(long) is not used in production code
Raw output
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @Repository and are declared in classes that  should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times):
Method de.tum.cit.aet.artemis.programming.repository.TemplateProgrammingExerciseParticipationRepository.findWithEagerResultsAndSubmissionsByProgrammingExerciseIdElseThrow(long) is not used in production code
	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:86)
	at com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule.check(ArchRule.java:165)
	at de.tum.cit.aet.artemis.shared.architecture.module.AbstractModuleRepositoryArchitectureTest.usedInProductionCode(AbstractModuleRepositoryArchitectureTest.java:215)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Check failure on line 0 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/architecture/ProgrammingServiceArchitectureTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

testCorrectAsyncCalls()

Junit test testCorrectAsyncCalls() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are annotated with @Async should not be called within the same class, because Methods annotated with @Async are meant to be executed in a new thread. The thread gets created in a Spring proxy subclass and requires the method to only be called from the outside.' was violated (1 times):
Method de.tum.cit.aet.artemis.programming.service.localvc.VcsAccessLogService.saveVcsAccesslog(de.tum.cit.aet.artemis.programming.domain.VcsAccessLog) should not be called from another Async method (LocalVCServletService.java:897)
Raw output
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are annotated with @Async should not be called within the same class, because Methods annotated with @Async are meant to be executed in a new thread. The thread gets created in a Spring proxy subclass and requires the method to only be called from the outside.' was violated (1 times):
Method de.tum.cit.aet.artemis.programming.service.localvc.VcsAccessLogService.saveVcsAccesslog(de.tum.cit.aet.artemis.programming.domain.VcsAccessLog) should not be called from another Async method (LocalVCServletService.java:897)
	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:86)
	at com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule.check(ArchRule.java:165)
	at de.tum.cit.aet.artemis.shared.architecture.module.AbstractModuleServiceArchitectureTest.testCorrectAsyncCalls(AbstractModuleServiceArchitectureTest.java:90)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Check failure on line 183 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/icl/LocalCIIntegrationTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

testNoParticipationWhenPushingToTestsRepository()

Junit test testNoParticipationWhenPushingToTestsRepository() failed java.lang.AssertionError: 
Expecting actual throwable to be an instance of:
  de.tum.cit.aet.artemis.core.exception.VersionControlException
but was:
  de.tum.cit.aet.artemis.core.exception.EntityNotFoundException: ProgrammingExerciseStudentParticipation
	at de.tum.cit.aet.artemis.core.repository.base.RepositoryImpl.lambda$getValueElseThrow$1(RepositoryImpl.java:64)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at de.tum.cit.aet.artemis.core.repository.base.RepositoryImpl.getValueElseThrow(RepositoryImpl.java:64)
	...(119 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
Raw output
java.lang.AssertionError: 
Expecting actual throwable to be an instance of:
  de.tum.cit.aet.artemis.core.exception.VersionControlException
but was:
  de.tum.cit.aet.artemis.core.exception.EntityNotFoundException: ProgrammingExerciseStudentParticipation
	at de.tum.cit.aet.artemis.core.repository.base.RepositoryImpl.lambda$getValueElseThrow$1(RepositoryImpl.java:64)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at de.tum.cit.aet.artemis.core.repository.base.RepositoryImpl.getValueElseThrow(RepositoryImpl.java:64)
	...(119 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
	at de.tum.cit.aet.artemis.programming.icl.LocalCIIntegrationTest.testNoParticipationWhenPushingToTestsRepository(LocalCIIntegrationTest.java:195)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)