Fix script to run examples locally #285
Conversation
Ignore comment lines and empty lines in the example lists file. Signed-off-by: Christoph Niethammer <[email protected]>
There was a problem hiding this comment.
Thank you for updating the script!
There is a minor mess with those test scripts as they are all kind of duplicated:
The workflow file differs a bit from the first two scripts but does basically the same (besides also comparing the results with the master branch).
However we can think of removing the run-validation.sh script since run-examples.sh is more sophisticated.
|
Yes, it would be good to unify the script to reduce code maintenance and use this then in the GitHub workflow as well. I will check and come back with an update for this PR. |
- Added command line options - Add one second timeout at end of test to easy interruption - Updated default run parameters to match run-validation script Signed-off-by: Christoph Niethammer <[email protected]>
|
Improved the run-example script so it can be reused in the run-validation script. The github workflow requires more logic than this simple local executor script as it checks for matching outputs from different branches. So I will not address this with this PR and I consider this to be ready for merging. |
Co-authored-by: FG-TUM <[email protected]>
Co-authored-by: FG-TUM <[email protected]>
| fi | ||
| cd ${repoPath}/examples/$(dirname $i) | ||
| cd ${repoPath}/examples | ||
| ./run-examples.sh -v --inputlist "${inputlist}" --logfile "${logfileName}" |
There was a problem hiding this comment.
You could also use the options --{mardyn,mpirun}_{exe,args} here. Or we could just get rid of the entire file since its use case is already covered by the default settings of run-examples.sh, isn't it?
There was a problem hiding this comment.
Good point. I could not find any use case inside the codebase/workflows so I would get rid of the validation.sh script then.
Co-authored-by: HomesGH <[email protected]>
Co-authored-by: FG-TUM <[email protected]>
Fixes problems reported in #284 for the
examples/run-examples.shscript and makes it work again.