Fix script to run examples locally #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore comment lines and empty lines in the example lists file. Signed-off-by: Christoph Niethammer <[email protected]>
HomesGH
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Thank you for updating the script!
There is a minor mess with those test scripts as they are all kind of duplicated:
The workflow file differs a bit from the first two scripts but does basically the same (besides also comparing the results with the master branch).
However we can think of removing the run-validation.sh script since run-examples.sh is more sophisticated.
|
Yes, it would be good to unify the script to reduce code maintenance and use this then in the GitHub workflow as well. I will check and come back with an update for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems reported in #284 for the
examples/run-examples.shscript and makes it work again.