-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugin loader (#2052) #2053
Conversation
The lxqt-plugin binary needs to export symbols that should be visible to plugins being loaded with QPluginLoader or dlopen.
Thanks for the fix, I can confirm it works. Just an issue: https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_ENABLE_EXPORTS.html says CMAKE_EXECUTABLE_ENABLE_EXPORTS is added in CMake 3.27. I'm not sure if it's too new for Linux/BSD/... distributions. |
Indeed it's on the edge: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMAKE_EXECUTABLE_ENABLE_EXPORTS
was introduces in version 3.27 released in Jul 2023. Too recent IMO.
We can use the ENABLE_EXPORTS
property:
set_property(TARGET ${PROJECT} PROPERTY ENABLE_EXPORTS TRUE)
It fixes the problem and it's available in the CMake versions we support.
This may deserve a point release. Please decide what should be done. @luis-pereira, @yan12125? |
This approach looks good (not tested yet) |
Pls test. It worked on my test. |
If |
For what it is worth, worked for me. Thank you! |
@luis-pereira |
@tsujan Done here |
Superseded by #2061 |
The lxqt-plugin binary needs to export symbols that should be visible to plugins being loaded with QPluginLoader or dlopen.
Fixes #2052