Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a plugin loader runtime failure #2061

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

luis-pereira
Copy link
Member

The plugins must export the symbols to allow loading by the panel executable.
CMAKE_EXECUTABLE_ENABLE_EXPORTS is too new for us.

Supersedes #2053. Fixes #2052.

The plugins must export the symbols to allow loading by the panel
executable.
CMAKE_EXECUTABLE_ENABLE_EXPORTS is too new for us.

Supersedes #2053.
Fixes #2052.
Copy link
Member

@tsujan tsujan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM.

Any objection to merging?

Copy link
Member

@yan12125 yan12125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works fine.

@tsujan tsujan merged commit a49e814 into master May 7, 2024
0 of 2 checks passed
@tsujan tsujan deleted the fix-plugin-loader-runtime branch May 7, 2024 14:41
@tsujan
Copy link
Member

tsujan commented May 7, 2024

Thanks! Will make point releases for this and lxqt/libfm-qt#972 soon — perhaps tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants