add CPPFLAGS to Makefile so that compiled in 64-bit mode by default #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason to use MUMmer3 vs. MUMmer4 that does not have these limitations? |
|
Hi @gmarcais The memory consumption is quite different between MUMmer3 vs. MUMmer4. This is my sole reason for using version 3 as opposed to the newest version. EDIT: Also, I would be happy to e-mail you some plots detailing this. Feel free to ping me as well. My view of the situation is that it is totally fine to have both versions 3 and 4, but that version 3 doesn't necessarily need to be "unchanged" given version 4 exists. Given the community uses both versions (I think), I think it would make sense to compile the code by default in 64-bit mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @brianwalenz @aphillippy
In case it is considered sensible to make this default behavior, I've added the C/C++ preprocessor flags in the Makefile so that MUMmer is compiled in 64-bit mode.
Naturally, I may be missing something---perhaps this shouldn't be default behavior, or this better belongs in the README. If so, I'm happy to close the PR.