[DST-462]Refactor <Dialog> component use Grid Areas #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 201c1d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage report
Show files with reduced coverage 🔻
Test suite run success573 tests passing in 78 suites. Report generated by 🧪jest coverage report action from 201c1d4 |
OsamaAbdellateef
changed the title
sarahgm
requested changes
Sep 24, 2024
sarahgm
reviewed
Sep 24, 2024
|
also documentation is missing |
github-actions
bot
added
the
type:docs
|
Ah I also noticed, this change require a UI kit update right? @OsamaAbdellateef |
Yes you are right @sarahgm 👏🏻 |
sarahgm
reviewed
Oct 1, 2024
1 task
sarahgm
reviewed
Oct 7, 2024
sarahgm
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR contains a breaking change! See below. This should be merged with #4187
Description
Our current API for the component is rather cumbersome and has some hard limitation when it comes to composability. We should improve this and align its API with the API of our other components (Components have their children “attached” e.g. Table.Cell)
What should be tested?
-The title and close button are vertically aligned
-The dialog is more composable
-The order of dialog sub-components always are the same
Reviewers:
@marigold-ui/developer